Skip to content

Historical large-file FIXME markers overstated the remaining live issue

Summary

This item originally treated three historical // FIXME LARGE FILES markers as active correctness bugs. Revalidation on current main showed that only one live issue remained: Kad metadata values in MetaDataDlg.cpp could still be formatted through the 32-bit helper even though Kad integer tags already support 64-bit values. The other two markers were stale historical notes rather than current large-file breakage.

Locations

File Line Note
srchybrid/MetaDataDlg.cpp 345 Kad tag integer formatting used the 32-bit display helper for generic numeric values
srchybrid/SearchList.cpp 703 Historical marker removed after revalidation confirmed the Kad search path already carries uint64 size and serializes it correctly
srchybrid/AICHSyncThread.cpp 367 Historical marker removed; the commented legacy-file delete is migration-tail policy, not missing large-file support

Impact

Before the fix, large Kad numeric metadata values, including file-size-like values, could display incorrectly in the metadata dialog because the generic Kad integer formatter narrowed them through GetFormatedUInt((UINT)...).

The other two locations did not represent live large-file handling failures on current main; they were misleading markers that overstated remaining work.

Resolution

  • MetaDataDlg.cpp now formats generic Kad integer values with the 64-bit helper.
  • The stale FIXME LARGE FILES markers in SearchList.cpp and AICHSyncThread.cpp were removed/reworded to reflect current intent.
  • Backlog scope was corrected to match the live code instead of the historical marker wording.

Landed

  • main: a0a7d18 (BUG-003: clean up stale large-file markers)

Files

  • srchybrid/AICHSyncThread.cpp:367
  • srchybrid/MetaDataDlg.cpp:345
  • srchybrid/SearchList.cpp:703