Skip to content

Remove or restore dead DebugSourceExchange log calls in DownloadQueue.cpp

Summary

This item originally tracked two srchybrid/DownloadQueue.cpp debug log calls that were commented out during development and never re-enabled:

// DownloadQueue.cpp:481
//if (thePrefs.GetDebugSourceExchange()) // TODO: Uncomment after testing

// DownloadQueue.cpp:557
//if (thePrefs.GetDebugSourceExchange()) // TODO: Uncomment after testing

These were dormant with an explicit "TODO: Uncomment after testing" note. Source Exchange v1 removal is complete under REF-002, so no separate REF-005 code cleanup remains.

Current Mainline Status

Done on main. REF-002 has removed the obsolete SX1 live-network path, and the stale TODO: Uncomment after testing comments are no longer present in DownloadQueue.cpp.

Current source-exchange debug logging is active behind thePrefs.GetDebugSourceExchange() for:

  • passive source receive logging (SXRecv)
  • skipped local server source requests with status detail (SXSend)
  • sent local server source requests (SXSend)

Fix

If REF-002 (Source Exchange v1 removal) lands first: delete these lines as part of that cleanup.

If addressed independently: either restore the calls properly or delete them — the TODO is stale.

Dependency

Blocked on or superseded by: REF-002.

Files

  • srchybrid/DownloadQueue.cpp:481
  • srchybrid/DownloadQueue.cpp:557

Acceptance Criteria

  • [x] No TODO: Uncomment after testing source-exchange debug comments remain in DownloadQueue.cpp.
  • [x] Source-exchange receive/send debug messages that still apply are live behind thePrefs.GetDebugSourceExchange().
  • [x] REF-002 owns the completed SX1 removal; REF-005 no longer tracks a separate code change.