Skip to content

Remove defunct PeerCache surface and legacy INI fallback reads

Summary

Current main no longer carries the defunct PeerCache packet/capability surface, and Preferences.cpp no longer reads the old FileBufferSizePref and QueueSizePref load-time fallback keys.

This landed as:

  • 6751a50 REF-018 remove defunct PeerCache surface

What Landed

Defunct PeerCache packet and constant removal

Removed the dead PeerCache packet surface from current main:

  • OP_PEERCACHE_QUERY
  • OP_PEERCACHE_ANSWER
  • OP_PEERCACHE_ACK
  • PCPCK_VERSION
  • PCOP_*
  • PCTAG_*

Touched files:

  • srchybrid/Opcodes.h
  • srchybrid/ListenSocket.cpp
  • srchybrid/OtherFunctions.cpp

Inert PeerCache capability cleanup

Removed the remaining dead PeerCache capability bookkeeping from the client hello path:

  • removed m_fPeerCache
  • removed SupportPeerCache()
  • removed the PeerCache=%u debug hello string
  • removed the dead commented public-IP request block gated by m_fPeerCache
  • removed the always-zero outgoing uPeerCache composition term

Touched files:

  • srchybrid/BaseClient.cpp
  • srchybrid/UpdownClient.h

Legacy INI fallback reads removed

Preferences.cpp now loads only the current keys:

  • FileBufferSize
  • QueueSize

The save-side DeleteKey(...) cleanup for the old names remains as harmless hygiene:

  • FileBufferSizePref
  • QueueSizePref

Revalidation Notes

The older backlog wording bundled a Win95 runtime-detection cleanup into REF-018. Revalidation against current main showed that scope was stale and not a meaningful live subtask anymore, so it was not forced into this change.

Acceptance

  • [x] No OP_PEERCACHE_QUERY/ANSWER/ACK references remain in current main
  • [x] No live PeerCache capability state remains in BaseClient.cpp / UpdownClient.h
  • [x] Preferences.cpp no longer reads FileBufferSizePref
  • [x] Preferences.cpp no longer reads QueueSizePref
  • [x] Supported build-app --config Debug --platform x64 passed after the change

Validation

  • build-app --config Debug --platform x64
  • Build artifact:
  • workspaces\v0.72a\state\build-logs\20260418-223305\summary.json